https://gitlab.synchro.net/main/sbbs/-/commit/a401004cd4401616a2a2312f
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove debug log line inadvertently left in

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8b6210dcaf2e3b49ed16f110
Modified Files:
src/sbbs3/main.cpp
Log Message:
Destroy the nodefile_mutex in sbbs_t destructor

This could've been a small memory leak

Also using [F]CLOSE_OPEN_FILE function-like macros to simplify code

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/819d26b6c593606c3e2e2497
Modified Files:
src/sbbs3/main.cpp
Log Message:
Simplify/correct the node status fixup upon client connect

- when we treat a non-WFC node status the same as WFC because the node_socket
is invalid, don't call lprintf(LOG_CRIT, ...) with the node logged. That's
ultimately going to call errormsg() which is going to try to increment the
node's critical error counter and fail or deadlock because the node's
record is already locked. Log the error after we call putnodedat() and the
node record has been unlocked.
- The "status is WFC" while the node_socket is valid check would always fail
because we already checked the node_socket validity at the top of the loop
so just remove this check/error message as dead code

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/80137a5129d974935681c478
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log the corrected node status value (error caught be GCC printf-validation)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5c099d90d119dd447133160b
Modified Files:
src/sbbs3/main.cpp
Log Message:
Replace break accidentally removed in previous commit

Would mark all nodes as at the prompt up new connection (big whoops)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/783473d285db5e03b445a9fb
Modified Files:
src/sbbs3/main.cpp
Log Message:
Correct node status stuck in "logout" status too (abnormal condition)

"LOGOUT" is another node status where the socket should be valid

Since my Debian 13 (and Samba) upgrade, I've been getting a lot of node.dab
and mail base corruption. Some of these conditions can be auto-corrected and this is one of them.

Removed some obsolete comments about old crash reports.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/43328cad606fde38aec86eea
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix potential socket leak upon server termination

caught/reported by Claude via Deuce

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6e49cb9c959c7e1710a1ac09
Modified Files:
src/sbbs3/main.cpp
Log Message:
Coverity complained about this unnecessary invalidation of client_socket here

CID 644869

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b598dcbb541ca8ddf8a083d8
Modified Files:
src/sbbs3/main.cpp
Log Message:
Insure all alert() output begins in the first (left-most) column

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ff1aae498b3464b1f2fd050a
Modified Files:
src/sbbs3/main.cpp
Log Message:
sbbs3 terminal server: drop unsent goodbye output before close_socket

In the four listener exit paths that queue output via the listener
pseudo-sbbs (CLIENT BLOCKED for ip.can / host.can, "no nodes
available", node init failure), call sbbs->rioctl(IOFB) right after flush_output() and before close_socket(). Without this, any
text/badip.msg / badhost.msg / nonodes.txt residue that didn't make
it out within the flush timeout sits in the ring buffer; when the
output thread next wakes it tries to send the leftover on the
now-closed FD, and the failed send logs a noisy warning (e.g.
"!ERROR 22 (...)" or "!ERROR 58 (...)" sending on socket).

This is the same idiom as the existing rioctl(IOFB) at the start of
the per-connection setup (main.cpp:5795) Ä purge stale buffer state
before changing socket lifecycle.

It does not eliminate the race entirely: data already pulled from
the ring buffer into the output thread's linear buffer is still sent
(or attempted), since rioctl operates on the ring buffer only. The
remaining noise is handled separately by demoting the typical
post-shutdown send errors (ESHUTDOWN, EINVAL) to LOG_NOTICE.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8c6da8b2eee4363c1fcb9925
Modified Files:
src/sbbs3/main.cpp
Log Message:
sbbs3 terminal server: include socket/protocol/IP in output_thread send-error logs

Three coordinated changes to output_thread's SOCKET_ERROR handling:

* Switch all six log lines from "<node-name> ..." (using sbbs->client_name
like "Terminal Server" / "Node N") to the standard "%04d %s [%s] ..."
prefix used by every other connection log line in the file. This
groups send errors with the matching "Connection accepted",
"!CLIENT BLOCKED", etc. lines for easy correlation. Capture
client_socket.load() once into a local since the cascade reads it
six times (it's std::atomic).

* Populate the listener pseudo-sbbs's client.protocol and client_ipaddr
per-connection. These were previously only set inside sbbs_t::init()
for per-node sbbs's (main.cpp:3639), leaving the listener's
output_thread with empty strings to print.

* Demote ESHUTDOWN and EINVAL send errors to LOG_NOTICE alongside the
existing ENOTSOCK / ECONNRESET / ECONNABORTED handlers. Both are
the typical errors raised when the listener races with close_socket()
on a blocked client (post-shutdown / mid-close socket state).
Treating them as expected disconnect noise matches the existing
pattern. Note: on POSIX, EINVAL from send() can theoretically
indicate a programming bug rather than a socket-state race, but in
practice it's the same race as on Windows and the noise reduction
is worth the small risk of masking.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/88889e94e52406ca3ff0b721
Modified Files:
src/sbbs3/main.cpp
Log Message:
node_thread: avoid throttle-loop hang on loginAttempts() failure (CID 645970)

loginAttempts() returns long and is documented to return a negative
value on failure, but the result was stored in a uint. On -1 the value
became UINT_MAX, passed the (> 1) check, and the throttle loop would
run ~4 billion mswait() iterations. Match the signed return type and
update the matching format specifier and loop counter.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ded9a017f3b2199433125aad
Modified Files:
src/sbbs3/main.cpp
Log Message:
sbbs_t::lputs: guard event-thread log-level check against null startup (CID 543171)

sbbs_t::lputs() consults startup->event_log_level when is_event_thread
is set, but the surrounding callers (e.g. sbbs_t::js_create_user_objects) already treat startup as potentially-null. If any caller reaches an errprintf/lprintf path with startup == nullptr while is_event_thread is
true, the deref would crash. Add the null check that the call sites
already assume.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ae00ca271149cf268b913ae8
Modified Files:
src/sbbs3/main.cpp
Log Message:
main: suppress ssh_mutex/sftp_state inter-procedural FPs (CIDs 469167, 487167)

CID 469167 (output_thread SLEEP): GCESSTR's lprintf runs while
ssh_mutex is held. Releasing+reacquiring the mutex around the SSH
error report would race the surrounding error-handling sequence
(ssh_errors++, online=FALSE) and is the wrong tradeoff for a fast log
write. Annotate as intentional design.

CID 487167 (crypt_pop_channel_data LOCK at function end): sftp_state->mtx
is acquired+released entirely inside sftps_recv;
crypt_pop_channel_data never holds it across return. Coverity
propagates a phantom lock state through the helper.

Note: CID 487173 (sftp_send LOCK leak in src/sbbs3/sftp.cpp) was
already mitigated in current source Ä every error path now releases
ssh_mutex before returning.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d6d35429bd173a0284d8fc5a
Modified Files:
src/sbbs3/main.cpp
Log Message:
main: cast cryptSetAttribute SSH_CHANNEL_ACTIVE deactivation to void (CID 487166)

In crypt_pop_channel_data the inner cryptSetAttribute that flips the
selected channel inactive is best-effort (we're tearing down anyway).
Make the discarded return explicit.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net