• src/sbbs3/main.cpp

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, August 03, 2024 19:58:06
    https://gitlab.synchro.net/main/sbbs/-/commit/c03ed4b9ce042d5651575e18
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Log a warning if any socket inactivity max durations are shorter/equal to ...

    to the getkey inactivity timeout.

    By setting a socket timeout shorter or equal to the getkey timeout, the getkey timeout effectively does nothing.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, October 13, 2024 13:36:54
    https://gitlab.synchro.net/main/sbbs/-/commit/2ce9ccfe50ab05c3bacf2e8d
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Reset sbbs_t menu path vars (menu_dir and menu_file) before execing cmd shell

    I obvserved an issue with Amessyroom's bbs where his custom (JS) shell is setting bbs.menu_dir but when switching to another stock shell, his menu
    files were still being displayed (with mismatching command keys as a result).

    bbs.menu_dir (and implicitly, the set_menu_dir Baja function) apparently have not been used in this way (much) before.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, November 12, 2024 20:08:02
    https://gitlab.synchro.net/main/sbbs/-/commit/ccab84c359406ffea9695db3
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Use new FILE_RETRY_ERRNO() macro for sopen() retries in sbbs_t::nopen()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, November 14, 2024 20:07:31
    https://gitlab.synchro.net/main/sbbs/-/commit/27e30f1277531509630d3ca8
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Better support for multiple hosts handling QWK events

    First, fix the logged username bug in the "Lock exists" log message.
    Next, double check that the trigger file (sem file or REP file) still exists after acquiring the file mutex.

    Use a temp varible (fname) to make the code easier to read.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, November 14, 2024 20:55:21
    https://gitlab.synchro.net/main/sbbs/-/commit/5956805f6e2e985824a86d52
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Log event command-lines (repeating event code was redundant)

    Only log messages about QWK mutex files existing when > 60 seconds old

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thursday, November 14, 2024 21:09:21
    https://gitlab.synchro.net/main/sbbs/-/commit/3127e4f4b89c73263cadd901
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Detect hung event_thread and log details

    Add log message when spawning background timed event

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, November 15, 2024 12:20:16
    https://gitlab.synchro.net/main/sbbs/-/commit/6df88451e8d9ce67c27bd4d0
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Use timestr() instead of ctime_r() for logging full date/times

    Also when detecting a blocked event_thread, log the event_code that is/was running last.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, November 15, 2024 12:26:02
    https://gitlab.synchro.net/main/sbbs/-/commit/87b22bda88174a8e03e25558
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Reolve !ERROR 2 (No such file or directory) removing "data/pack####.now"

    glob() results might be out of date by the time we look at each file, just
    skip missing QWK pack semaphore files silently. This should resolve the
    ".now already gone" messages too. Hopefully.

    Removed some extraneous quotes around logged event command-lines.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, November 15, 2024 18:29:09
    https://gitlab.synchro.net/main/sbbs/-/commit/f37e9789f42d73d4991d2ff3
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Use fmutex_open() instead of fmutex() to better protect the pack*.lock files

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, November 15, 2024 22:17:53
    https://gitlab.synchro.net/main/sbbs/-/commit/6dda18740c154c5f099070d1
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Use fmutex_close() and don't log ENOENT errors when removing pack*.now files

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, November 15, 2024 22:37:59
    https://gitlab.synchro.net/main/sbbs/-/commit/208f263b94e85ef91dc62cc3
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Just a little wording update on the fmutex file open log message

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, November 17, 2024 03:02:57
    https://gitlab.synchro.net/main/sbbs/-/commit/2fa8db2b6a1a5da43db71887
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Perform "first level Ctrl-C input checking" even when in Telnet BINARY_TX

    This condition caused aborting BBS operations via Ctrl-C to fail when connecting from a traditional Telnet client using binary transmission
    mode (e.g. telnet -8) or SyncTERM v1.2rc6.

    The check of rio_abortable was probably enough to disable this function
    during file transfers (e.g. we've had no issues with SSH file transfers
    that might include byte 0x03 received from the client), but I added the
    check for SS_FILEXFER system status check too, perhaps unnecessary.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, November 18, 2024 22:11:42
    https://gitlab.synchro.net/main/sbbs/-/commit/6d7f85680177ba6fef1946f2
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't use uninitialized variable: lockfname

    Where's the compiler warnings guys?

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Tuesday, November 19, 2024 22:55:43
    https://gitlab.synchro.net/main/sbbs/-/commit/fa5321fe8850f6d2d9558312
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    request_telnet_opt() will ignore all cmds but DO, DONT, WILL and WONT

    This allows us to save unitialized telnet_*_option values (i.e. 0x00) and pass those values back to request_telnet_opt() with no side effect.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, January 20, 2025 20:37:00
    https://gitlab.synchro.net/main/sbbs/-/commit/3bf096b52465792776df3787
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Make JS global alert() and deny() methods inline with jsexec versions

    alert() doesn't throw exception on null/undefined, just no arg

    deny() throws exception on no args or null/undefined arg

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, February 09, 2025 00:09:25
    https://gitlab.synchro.net/main/sbbs/-/commit/64352121b6727a90eee5e848
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't attempt to remove inbound QWK packet if doesn't exist (renamed?)

    Address error report by Greg Meckel (THEICECA)
    evnt QNET !ERROR 2 (No such file or directory) (EinError 2) in main.cpp line 3195 (event_thread) removing "C:\sbbs\data\VERT.qwk" access=0

    ... this could happen after a bad QWK packet was detected and renamed.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sunday, March 23, 2025 18:11:53
    https://gitlab.synchro.net/main/sbbs/-/commit/6a0971f6e79ec18c2ed611dc
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    filelength() can return -1 on error, deal

    Just caught during code review

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sunday, March 23, 2025 18:11:54
    https://gitlab.synchro.net/main/sbbs/-/commit/0ac5ed5728c53d93eb347c23
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Set node "interrupt" flag to try to gracefully disconnect user blocking event

    When a timed event is configured to run "exclusively", all nodes need to not be in in-use. As it was, after waiting 60 minutes for the online user(s) to
    notice they'd run out of time and disconnect, we'd just (rather ungracefully) close the sockets used by such node(s) connections. This results in same logged errors about trying to send to bad socket descriptors and provides no feedback to the user about why they were disconnected.

    Since we have the node interrupt flag (which hopefully, all scripts are checking via node_sync) - use that to try to more gracefully terminate the user's session/connection after 30 minutes of waiting for the user to disconnect.

    If after 60 minutes of waiting, the node is still in-use, we still do the socket disconnection method.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thursday, April 10, 2025 14:57:08
    https://gitlab.synchro.net/main/sbbs/-/commit/aea882a8e4552b64c03c521d
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Initialize Terminal in global sbbs when answering

    Should fix issue where extra pauses occur on connection.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thursday, April 10, 2025 14:58:17
    https://gitlab.synchro.net/main/sbbs/-/commit/f218ad1fec992a71f590120e
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix typo (thrad->thread)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net