1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/un_qwk.cpp un_rep.cpp

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, September 11, 2024 20:26:18
    https://gitlab.synchro.net/main/sbbs/-/commit/29a35642160a7f4148134ce3

    Modified Files:
    src/sbbs3/un_qwk.cpp un_rep.cpp
    Log Message:
    Blocked IP addresses in ip-silent.can weren't filtered from QWK and REP pkts

    The "from_ip" header field of QWK messages is checked against blocked IP
    addresses, but was only checking against IP addresses from ip.can, not any
    addresses listed in ip-silent.can. These 2 list files are now merged together
    for the purposes of filtering during QWK/REP packet import.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thursday, September 12, 2024 21:37:53
    https://gitlab.synchro.net/main/sbbs/-/commit/aff554a44aa48a1e1565f450

    Modified Files:
    src/sbbs3/un_qwk.cpp un_rep.cpp
    Log Message:
    Fix crash due to use after free or double-free

    ... bug introduced in commit 29a35642160a7f4.

    strListMerge() doesn't realloc the strings in the list, so we don't want to
    free the strings in this list here.

    This is likely the cause of the crash Keyop eluded to in #synchronet.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net